Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove 'err' names from function return arguments in queriers #2788

Closed
fedekunze opened this issue Nov 12, 2018 · 2 comments
Closed

remove 'err' names from function return arguments in queriers #2788

fedekunze opened this issue Nov 12, 2018 · 2 comments
Labels
good first issue help wanted Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@fedekunze
Copy link
Collaborator

Originally posted by @rigelrozanski in #2565

Ref: #2565 (comment)

queriable.go uses err2/errRes for the error return values. For consistency let's use only err everywhere

@fedekunze fedekunze added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. help wanted good first issue labels Nov 12, 2018
@alexanderbez
Copy link
Contributor

alexanderbez commented Nov 12, 2018

Yes pweeeez 🙌

Also, we should remove named return variables where it's obviously clear what the context is and the function/method is concise.

@tac0turtle
Copy link
Member

@fedekunze & @alexanderbez has then been solved, seems the PR from 4ever9 solved most to all of them

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue help wanted Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

No branches or pull requests

3 participants