Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

R4R: Fix the bug in GetAccount when len(res) == 0 and err == nil #3141

Merged
merged 3 commits into from
Dec 21, 2018

Conversation

MrXJC
Copy link
Contributor

@MrXJC MrXJC commented Dec 18, 2018

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #3141 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3141      +/-   ##
===========================================
- Coverage    55.03%   55.01%   -0.03%     
===========================================
  Files          133      133              
  Lines         9434     9434              
===========================================
- Hits          5192     5190       -2     
- Misses        3925     3927       +2     
  Partials       317      317

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #3141 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3141      +/-   ##
===========================================
+ Coverage    54.82%   54.84%   +0.02%     
===========================================
  Files          133      133              
  Lines         9552     9548       -4     
===========================================
  Hits          5237     5237              
+ Misses        3994     3990       -4     
  Partials       321      321

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MrXJC -- the fix looks good. Mind adding a pending log entry?

@MrXJC
Copy link
Contributor Author

MrXJC commented Dec 21, 2018

Sorry, I was so late to add the pending log entry. @alexanderbez

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MrXJC 👍

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes cwgoes merged commit 2ce8722 into cosmos:develop Dec 21, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants