-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
R4R: Fix the bug in GetAccount when len(res) == 0 and err == nil #3141
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3141 +/- ##
===========================================
- Coverage 55.03% 55.01% -0.03%
===========================================
Files 133 133
Lines 9434 9434
===========================================
- Hits 5192 5190 -2
- Misses 3925 3927 +2
Partials 317 317 |
Codecov Report
@@ Coverage Diff @@
## develop #3141 +/- ##
===========================================
+ Coverage 54.82% 54.84% +0.02%
===========================================
Files 133 133
Lines 9552 9548 -4
===========================================
Hits 5237 5237
+ Misses 3994 3990 -4
Partials 321 321 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MrXJC -- the fix looks good. Mind adding a pending log entry?
Sorry, I was so late to add the pending log entry. @alexanderbez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @MrXJC 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: