Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

R4R: Distribution Queriers & CLI query commands #3319

Merged
merged 19 commits into from
Jan 18, 2019

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jan 17, 2019

Adds queriers and distribution CLI query commands for:

  • Module parameters
  • Outstanding (un-withdrawn) rewards
  • Outstanding validator commission
  • Validator slashes
  • Current delegator rewards (if they were to be withdrawn)

Closes #3307
Closes #2359

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes added API T: UX C:x/distribution distribution module related labels Jan 17, 2019
@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #3319 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3319      +/-   ##
===========================================
- Coverage    55.57%   55.55%   -0.03%     
===========================================
  Files          132      132              
  Lines         9528     9528              
===========================================
- Hits          5295     5293       -2     
- Misses        3898     3900       +2     
  Partials       335      335

@cwgoes cwgoes changed the title WIP: Distribution Queriers R4R: Distribution Queriers Jan 18, 2019
@cwgoes cwgoes added game-of-stakes and removed API labels Jan 18, 2019
@cwgoes cwgoes changed the title R4R: Distribution Queriers R4R: Distribution Queriers & CLI query commands Jan 18, 2019
@cwgoes cwgoes requested a review from zramsay as a code owner January 18, 2019 11:57
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good! Just have a few remarks 👍

fedekunze and others added 2 commits January 18, 2019 18:55
Co-Authored-By: cwgoes <cwgoes@pluranimity.org>
Co-Authored-By: cwgoes <cwgoes@pluranimity.org>
fedekunze and others added 7 commits January 18, 2019 18:55
Co-Authored-By: cwgoes <cwgoes@pluranimity.org>
Co-Authored-By: cwgoes <cwgoes@pluranimity.org>
Co-Authored-By: cwgoes <cwgoes@pluranimity.org>
Co-Authored-By: cwgoes <cwgoes@pluranimity.org>
Co-Authored-By: cwgoes <cwgoes@pluranimity.org>
Co-Authored-By: cwgoes <cwgoes@pluranimity.org>
@cwgoes cwgoes merged commit f65ae49 into develop Jan 18, 2019
@cwgoes cwgoes deleted the cwgoes/distribution-queriers branch January 18, 2019 19:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C:CLI C:x/distribution distribution module related T: UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants