Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

R4R: Assert store implementations never store nil values #3435

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jan 29, 2019

Closes #2707

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes changed the title WIP: Assert store implementations never store nil values R4R: Assert store implementations never store nil values Jan 29, 2019
@cwgoes cwgoes requested a review from mossid January 29, 2019 20:00
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #3435 into develop will increase coverage by 0.03%.
The diff coverage is 84.61%.

@@             Coverage Diff             @@
##           develop    #3435      +/-   ##
===========================================
+ Coverage    59.36%   59.39%   +0.03%     
===========================================
  Files          134      135       +1     
  Lines         9972     9975       +3     
===========================================
+ Hits          5920     5925       +5     
+ Misses        3679     3678       -1     
+ Partials       373      372       -1

@cwgoes cwgoes merged commit f66b7b6 into develop Jan 29, 2019
@cwgoes cwgoes deleted the cwgoes/add-store-impl-tests branch January 29, 2019 20:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants