Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

R4R: LCD proof verification #3449

Merged
merged 16 commits into from
Jan 30, 2019

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jan 30, 2019

Replaces #3191

Closes: #2432

Recreate the singleton verifier if the home directory has changed.

This means that LCD proofs now test lite client verification.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes
Copy link
Contributor Author

cwgoes commented Jan 30, 2019

Turns out LCD tests were not in fact using isolated directories, as they pass individually.

@cwgoes cwgoes changed the title LCD proof verification WIP: LCD proof verification Jan 30, 2019
@cwgoes
Copy link
Contributor Author

cwgoes commented Jan 30, 2019

The problem is the singleton verifier, I think.

@cwgoes cwgoes changed the title WIP: LCD proof verification R4R: LCD proof verification Jan 30, 2019
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #3449 into develop will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3449      +/-   ##
===========================================
- Coverage    59.49%   59.45%   -0.05%     
===========================================
  Files          135      135              
  Lines         9981     9981              
===========================================
- Hits          5938     5934       -4     
- Misses        3671     3675       +4     
  Partials       372      372

@cwgoes cwgoes merged commit bc193df into develop Jan 30, 2019
@cwgoes cwgoes deleted the cwgoes/HaoyangLiu-irisnet/proof-verification branch January 30, 2019 21:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants