Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Proposal Stringer #3986

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Fix Proposal Stringer #3986

merged 2 commits into from
Mar 27, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Mar 27, 2019

Fix the Stringer interface implementation for the Proposal type:

  • Add missing description
  • Fix indentation

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added C:x/gov WIP Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Mar 27, 2019
@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #3986 into develop will increase coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3986      +/-   ##
===========================================
+ Coverage     60.2%   60.23%   +0.02%     
===========================================
  Files          196      196              
  Lines        14551    14554       +3     
===========================================
+ Hits          8761     8767       +6     
+ Misses        5205     5203       -2     
+ Partials       585      584       -1

@alexanderbez alexanderbez marked this pull request as ready for review March 27, 2019 20:10
@alessio alessio merged commit f635b1c into develop Mar 27, 2019
@alessio alessio deleted the bez/fix-proposal-stringer branch March 27, 2019 21:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C:x/gov Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants