Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add category tags #4049

Merged
merged 7 commits into from
Apr 9, 2019
Merged

add category tags #4049

merged 7 commits into from
Apr 9, 2019

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented Apr 4, 2019 •
edited
Loading

Closes #3774

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze mentioned this pull request Apr 4, 2019
Closed
5 tasks
@fedekunze fedekunze marked this pull request as ready for review April 4, 2019 22:04
alexanderbez
alexanderbez suggested changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise LGTM.

@codecov
Copy link

codecov bot commented Apr 9, 2019 •
edited
Loading

Codecov Report

Merging #4049 into develop will increase coverage by <.01%.
The diff coverage is 70.83%.

@@             Coverage Diff             @@
##           develop    #4049      +/-   ##
===========================================
+ Coverage    59.95%   59.95%   +<.01%     
===========================================
  Files          212      212              
  Lines        15104    15122      +18     
===========================================
+ Hits          9056     9067      +11     
- Misses        5426     5433       +7     
  Partials       622      622

@fedekunze fedekunze added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Apr 9, 2019
@alessio alessio merged commit 2cd2289 into develop Apr 9, 2019
@alessio alessio deleted the fedekunze/3774-add-category-tags branch April 9, 2019 12:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alessio alessio alessio approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@faboweb faboweb Awaiting requested review from faboweb

Assignees
No one assigned
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fedekunze @alessio @alexanderbez @jackzampolin