Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove QueryTxsByTags or update to search with events. #4633

Closed
4 tasks
colin-axner opened this issue Jun 27, 2019 · 2 comments · Fixed by #4637
Closed
4 tasks

Remove QueryTxsByTags or update to search with events. #4633

colin-axner opened this issue Jun 27, 2019 · 2 comments · Fixed by #4637
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@colin-axner
Copy link
Contributor

Summary of Bug

Tags were removed in #4541. QueryTxsByTags is still used in the code to search with tags as shown here. This should either but removed or ideally rewritten to query by events.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@fedekunze
Copy link
Collaborator

Do we need to get this for 0.37 ? @jackzampolin @alexanderbez ?

@alexanderbez
Copy link
Contributor

alexanderbez commented Jun 28, 2019 •
edited
Loading

Errrr the underlying Tendermint query functionality is identical. We should rename it to QueryTxsByEvents. But good catch nonetheless @colin-axner 👍

@alexanderbez alexanderbez added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Jun 28, 2019
@alexanderbez alexanderbez mentioned this issue Jun 28, 2019
Merged
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Search Txs by Events APIs cosmos/cosmos-sdk
3 participants
@alexanderbez @colin-axner @fedekunze