Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

panic on non-registered store #4792

Merged
merged 7 commits into from
Jul 29, 2019
Merged

Conversation

rigelrozanski
Copy link
Contributor

mini PR
This would have been nice when debugging hellochain CC @hschoenburg

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK missing a pending entry

@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #4792 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4792      +/-   ##
==========================================
- Coverage   50.51%   50.49%   -0.02%     
==========================================
  Files         288      288              
  Lines       18517    18517              
==========================================
- Hits         9353     9351       -2     
- Misses       8479     8481       +2     
  Partials      685      685

@fedekunze fedekunze added the R4R label Jul 29, 2019
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@rigelrozanski rigelrozanski merged commit bd44492 into master Jul 29, 2019
@rigelrozanski rigelrozanski deleted the rigel/better-store-panic branch July 29, 2019 17:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants