Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Proposal messages are missing cosmos_proto.implements_interface option #1739

Closed
4 tasks
pyramation opened this issue Jul 20, 2022 · 0 comments · Fixed by #1740
Closed
4 tasks

Proposal messages are missing cosmos_proto.implements_interface option #1739

pyramation opened this issue Jul 20, 2022 · 0 comments · Fixed by #1740

Comments

@pyramation
Copy link
Contributor

Summary

related to cosmos-sdk issue here

in ADR 019 it states

In .proto files:
fields which accept interfaces should be annotated with cosmos_proto.accepts_interface using the same full-qualified name passed as protoName to InterfaceRegistry.RegisterInterface
interface implementations should be annotated with cosmos_proto.implements_interface using the same full-qualified name passed as protoName to InterfaceRegistry.RegisterInterface

In the future, protoName, cosmos_proto.accepts_interface, cosmos_proto.implements_interface may be used via code generation, reflection &/or static linting.

We're doing codegen, and we're missing many of the cosmos_proto.implements_interface: hyperweb-io/telescope#118 (comment)

If we can add these into the protos, it would help the codegen flow to make client-side serialization better.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant