Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ics27(upgrades): Ensure upgrade parameters are checked explicitly in app callbacks #5462

Closed
3 tasks
damiannolan opened this issue Dec 19, 2023 · 3 comments
Closed
3 tasks

ics27(upgrades): Ensure upgrade parameters are checked explicitly in app callbacks #5462

damiannolan opened this issue Dec 19, 2023 · 3 comments
Assignees
@colin-axner
Labels
audit Feedback from implementation audit channel-upgradability Channel upgradability feature type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
04-channel upgrad...

Comments

@damiannolan
Copy link
Contributor

Summary

  • OnChanUpgradeInit function on keeper should verify that proposed version is valid (only encoding, tx type can change), the order is valid and connection hops are valid.
  • OnChanUpgradeAck should ensure the version is valid doing the same checks as in ChanUpgradeInit. (can have common function they both call OR just make the checks explicit).
  • Document what can be changed in upgrade and what cannot.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added audit Feedback from implementation audit type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. channel-upgradability Channel upgradability feature labels Dec 19, 2023
@damiannolan damiannolan added this to the 04-channel upgrades RC milestone Dec 19, 2023
@colin-axner colin-axner self-assigned this Dec 20, 2023
@colin-axner colin-axner mentioned this issue Dec 20, 2023
Merged
9 tasks
@colin-axner
Copy link
Contributor

Is this needed for host?

@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jan 1, 2024
@crodriguezvega crodriguezvega moved this from Todo to In review in ibc-go Jan 1, 2024
@crodriguezvega
Copy link
Contributor

Is this needed for host?

I think so!

@crodriguezvega crodriguezvega mentioned this issue Jan 4, 2024
Merged
9 tasks
@crodriguezvega
Copy link
Contributor

Closed by #5472 and #5519

@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Jan 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@colin-axner colin-axner

Labels
audit Feedback from implementation audit channel-upgradability Channel upgradability feature type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Archived in project
Milestone
04-channel upgrades RC
Development

No branches or pull requests
3 participants
@damiannolan @crodriguezvega @colin-axner