Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Deprecate ErrPacketTimeout error #5600

Closed
2 of 3 tasks
DimitrisJim opened this issue Jan 15, 2024 · 5 comments · Fixed by #5626
Closed
2 of 3 tasks

Deprecate ErrPacketTimeout error #5600

DimitrisJim opened this issue Jan 15, 2024 · 5 comments · Fixed by #5626
Assignees
@natebeauregard
Labels
deprecated Issues to remove deprecated code good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Jan 15, 2024 •
edited
Loading

See following discussion #5572 (review). Usages of ErrPacketTimeout have been replaced by ErrTimeoutElapsed.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added the type: code hygiene Clean up code but without changing functionality or interfaces label Jan 15, 2024
@crodriguezvega crodriguezvega added the good first issue Good for newcomers label Jan 15, 2024
@natebeauregard
Copy link
Contributor

@DimitrisJim @crodriguezvega I can take a look at this!

@crodriguezvega
Copy link
Contributor

@DimitrisJim @crodriguezvega I can take a look at this!

Go for it, @natebeauregard. Thank you!

@natebeauregard
Copy link
Contributor

For this PR should I remove the ErrPacketTimeout error entirely or just add a comment like // Deprecated: ErrPacketTimeout is deprecated and will be removed in a future release. Please use ErrTimeoutElapsed instead. above the error?

@hoseincc
Copy link

♥️

@DimitrisJim
Copy link
Contributor Author

I'd go with deprecation @natebeauregard. We can check what the rest of the team thinks in the PR 😄

@natebeauregard natebeauregard mentioned this issue Jan 16, 2024
Merged
9 tasks
@DimitrisJim DimitrisJim added the deprecated Issues to remove deprecated code label Jan 22, 2024
@DimitrisJim DimitrisJim mentioned this issue Jan 26, 2024
Open
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@natebeauregard natebeauregard

Labels
deprecated Issues to remove deprecated code good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deprecated: deprecate ErrPacketTimeout error natebeauregard/ibc-go
4 participants
@crodriguezvega @DimitrisJim @natebeauregard @hoseincc