Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Pass ConsensusHost as arg to core ibc NewKeeper func #6082

Closed
3 tasks
damiannolan opened this issue Apr 3, 2024 · 0 comments · Fixed by #6084
Closed
3 tasks

Pass ConsensusHost as arg to core ibc NewKeeper func #6082

damiannolan opened this issue Apr 3, 2024 · 0 comments · Fixed by #6084
Assignees
@chatton
Labels
core type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
v9.0.0

Comments

@damiannolan
Copy link
Contributor

Summary

Follow up from #6055.

We can pass the ConsensusHost explicitly to ibc core's NewKeeper constructor, using 07-tendermint implmentation in simapp.

This should remove the need for passing StakingKeeper as an argument to ibc core. And instead it is passed to 07-tendermint NewConsensusHost().

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added core type: code hygiene Clean up code but without changing functionality or interfaces labels Apr 3, 2024
@damiannolan damiannolan added this to the v9.0.0 milestone Apr 3, 2024
@damiannolan damiannolan moved this to Todo 🏃 in ibc-go Apr 3, 2024
@chatton chatton self-assigned this Apr 3, 2024
@chatton chatton mentioned this issue Apr 3, 2024
Merged
10 tasks
@crodriguezvega crodriguezvega moved this from Todo 🏃 to In review 👀 in ibc-go Apr 3, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go Apr 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@chatton chatton

Labels
core type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
v9.0.0
Development

Successfully merging a pull request may close this issue.

Change signature of NewKeeper to directly accept a ConsensusHost cosmos/ibc-go
2 participants
@damiannolan @chatton