Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove Name method from app modules in favor of constant module name #7895

Open
technicallyty opened this issue Jan 28, 2025 · 0 comments
Open

Remove Name method from app modules in favor of constant module name #7895

technicallyty opened this issue Jan 28, 2025 · 0 comments
Labels
icebox Issues that we will not address for the time being

Comments

@technicallyty
Copy link
Contributor

with: #7886 we no longer need the Name method. we can just have a constant string and use it in the module map.

we can also remove the deprecated AppModule interface guard that required a Name method.
@gjermundgaraba gjermundgaraba added the icebox Issues that we will not address for the time being label Feb 6, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
icebox Issues that we will not address for the time being
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gjermundgaraba @technicallyty