From 012d3456bd8956391ffdc60d505042173cf81a88 Mon Sep 17 00:00:00 2001 From: chandiniv1 Date: Tue, 19 Dec 2023 11:38:00 +0530 Subject: [PATCH 1/2] modify maxmemocharlength --- modules/apps/27-interchain-accounts/types/packet.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/apps/27-interchain-accounts/types/packet.go b/modules/apps/27-interchain-accounts/types/packet.go index 524e2ebc44a..fea649dfac1 100644 --- a/modules/apps/27-interchain-accounts/types/packet.go +++ b/modules/apps/27-interchain-accounts/types/packet.go @@ -19,7 +19,7 @@ var ( ) // MaxMemoCharLength defines the maximum length for the InterchainAccountPacketData memo field -const MaxMemoCharLength = 256 +const MaxMemoCharLength = 32768 var ( // DefaultRelativePacketTimeoutHeight is the default packet timeout height (in blocks) relative From 8f2d2aa9af2c5073c80ef4c6a909be51eb6d2162 Mon Sep 17 00:00:00 2001 From: chandiniv1 Date: Wed, 20 Dec 2023 10:51:04 +0530 Subject: [PATCH 2/2] remove memo --- modules/apps/27-interchain-accounts/types/packet_test.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/modules/apps/27-interchain-accounts/types/packet_test.go b/modules/apps/27-interchain-accounts/types/packet_test.go index b8dd1043743..3f55c1f45a8 100644 --- a/modules/apps/27-interchain-accounts/types/packet_test.go +++ b/modules/apps/27-interchain-accounts/types/packet_test.go @@ -7,8 +7,6 @@ import ( ibctesting "github.com/cosmos/ibc-go/v8/testing" ) -var largeMemo = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum" - func (suite *TypesTestSuite) TestValidateBasic() { testCases := []struct { name string @@ -64,7 +62,7 @@ func (suite *TypesTestSuite) TestValidateBasic() { types.InterchainAccountPacketData{ Type: types.EXECUTE_TX, Data: []byte("data"), - Memo: largeMemo, + Memo: ibctesting.GenerateString(types.MaxMemoCharLength + 1), }, false, },