-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
(feat) Add possibility to transfer entire balance. (backport #6877) #6920
(feat) Add possibility to transfer entire balance. (backport #6877) #6920
Conversation
* Add possibility to transfer entire balance. * Added entry to the Changelog. * Added e2e test * Added forwarding * Update modules/apps/transfer/keeper/relay.go Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * Move UnboundedSpendLimit to token.go * add documentation * add test to compatibility matrices * PR Feedback. --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 92e1f38) # Conflicts: # .github/compatibility-test-matrices/release-v9.0.x/transfer-v2-multidenom-chain-a.json
Cherry-pick of 92e1f38 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
where are the conflicts in this PR? 🤔 was it file deletion? |
seems so: CONFLICT (modify/delete): .github/compatibility-test-matrices/release-v9.0.x/transfer-v2-multidenom-chain-a.json deleted in HEAD and modified in 92e1f387b ((feat) Add possibility to transfer entire balance. (#6877)). Version 92e1f387b ((feat) Add possibility to transfer entire balance. (#6877)) of .github/compatibility-test-matrices/release-v9.0.x/transfer-v2-multidenom-chain-a.json left in tree. think we can just move forward with it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I deleted all the e2e I will delete it in a separatePR. Maybe in a separate PR we could also delete compatibility matrices and docs.
This reverts commit 71db49e.
# Conflicts: # e2e/tests/transfer/base_test.go
|
Description
closes: #6567
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.This is an automatic backport of pull request #6877 done by [Mergify](https://mergify.com).