Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Avoid unnecessary validation and allocations in ClientId::new #1014

Closed
mina86 opened this issue Dec 21, 2023 · 0 comments · Fixed by #1015
Closed

Avoid unnecessary validation and allocations in ClientId::new #1014

mina86 opened this issue Dec 21, 2023 · 0 comments · Fixed by #1015

Comments

@mina86
Copy link
Contributor

mina86 commented Dec 21, 2023

Feature Summary

ClientId::new unnecessarily takes ClientType’s ownership and creates a temporary string. Furthermore, it performs validations which we know will pass since it takes ClientType which is valid.

Proposal

PR incoming
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

imp: avoid unnecessary clones and validations when creating ClientId mina86/ibc-rs
1 participant
@mina86