Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

conn_open_init() should hardcode counterparty connection id to None #174

Closed
2 of 5 tasks
plafer opened this issue Oct 12, 2022 · 0 comments · Fixed by #272
Closed
2 of 5 tasks

conn_open_init() should hardcode counterparty connection id to None #174

plafer opened this issue Oct 12, 2022 · 0 comments · Fixed by #272
Labels
A: bug Admin: something isn't working A: good-first-issue Admin: good for newcomers

Comments

@plafer
Copy link
Contributor

plafer commented Oct 12, 2022

Summary of Bug

Currently in conn_open_init, we set the counterparty to whatever is in the message. The spec mandates the counterparty_connection_id to be set to "" (None in our case). In other words, our implementation needlessly relies on the relayer to properly set the counterparty connection ID to None.

Related: cosmos/ibc#854

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@plafer plafer added A: bug Admin: something isn't working A: good-first-issue Admin: good for newcomers labels Oct 12, 2022
@plafer plafer mentioned this issue Oct 12, 2022
Closed
3 tasks
livelybug added a commit to octopus-network/ibc-rs that referenced this issue Oct 14, 2022
@livelybug
Merge pull request informalsystems#174 from octopus-network/feature/b…
6515624 
…eefy-m2

Remove MMR update service
This was referenced Nov 29, 2022
Merged
Closed
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@dependabot @crodriguezvega
Bump eslint-plugin-prettier from 4.0.0 to 4.2.1 in /js (informalsyste…
5f7c0c1 
…ms#174)

Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 4.0.0 to 4.2.1.
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md)
- [Commits](prettier/eslint-plugin-prettier@v4.0.0...v4.2.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A: bug Admin: something isn't working A: good-first-issue Admin: good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set counterparty_connection_id to None in conn_open_init
1 participant
@plafer