Finish implementation of Validation/ExecutionContext
#393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 58.45% // Head: 55.69% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
- Coverage 58.45% 55.69% -2.77%
==========================================
Files 124 122 -2
Lines 16259 17065 +806
==========================================
Hits 9505 9505
- Misses 6754 7560 +806
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@Farhad-Shabani last changes are in (regarding ICS-20 validation for acknowledgement and timeout callbacks): |
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* timeout validate scaffolding * validate still not done * complete timeout validate * timeout validate: accept noop * timeout packet execute * timeout_on_close validation * timeout_on_close done * ack validate * Acknowledgement execute * fix on_timeout_validate * ics20 new ack cbs * ics-20 new timeout cb * PacketError * ack: move ordered check * ics-20 ack packet validate * ics-20 refund packet validate * changelog
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #322
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.