Skip to content

[ICS02] Replace specific verify_functions with generic verify_membership and verify_non_membership #530

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Tracked by #173
Farhad-Shabani opened this issue Mar 14, 2023 · 0 comments · Fixed by #531
Assignees
Labels
A: breaking Admin: breaking change that may impact operators O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Summary

In continuation of #404, part of #173, aiming toward cosmos/ibc#684 implementation in IBC-rs
Replace specific verify_functions of ClientState trait with generic verify_membership and verify_non_membership methods

Proposal

By separating the verify_conn_delay_passed process from the proof verification steps and isolating the concern, it has become apparent that the proof verification method in ics02-clienstate is carrying out a very similar task. With some minor refactoring, we can make use of generic interfaces and impose fewer implementation requirements on the builders.

@Farhad-Shabani Farhad-Shabani added A: breaking Admin: breaking change that may impact operators O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding labels Mar 14, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.33.0 milestone Mar 14, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Mar 14, 2023
@Farhad-Shabani Farhad-Shabani moved this to 🔖 Needs Review in ibc-rs Mar 14, 2023
@Farhad-Shabani Farhad-Shabani changed the title [ICS02_ClientState] Replace specific verify_functions with generic verify_membership and verify_non_membership [ICS02] Replace specific verify_functions with generic verify_membership and verify_non_membership Mar 14, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Needs Review to ✅ Done in ibc-rs Mar 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A: breaking Admin: breaking change that may impact operators O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant