Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove Header trait #617

Closed
plafer opened this issue Apr 13, 2023 · 1 comment · Fixed by #730
Closed

Remove Header trait #617

plafer opened this issue Apr 13, 2023 · 1 comment · Fixed by #730
Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews O: code-hygiene Objective: aims to improve code hygiene
Milestone
v0.42.0

Comments

@plafer
Copy link
Contributor

plafer commented Apr 13, 2023

The Header trait is only used in tests, and doesn't serve a clear purpose. We should remove it.
@plafer plafer added O: code-hygiene Objective: aims to improve code hygiene A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews labels Apr 13, 2023
@plafer plafer mentioned this issue Apr 13, 2023
Merged
23 tasks
@Farhad-Shabani Farhad-Shabani moved this to 📥 To Do in ibc-rs Apr 13, 2023
@DaviRain-Su
Copy link
Contributor

In ibc-go use ClientMessage to Update ClientState, replace Header.

@Farhad-Shabani Farhad-Shabani mentioned this issue Jun 13, 2023
Closed
@DaviRain-Su DaviRain-Su mentioned this issue Jun 25, 2023
Merged
7 tasks
plafer pushed a commit that referenced this issue Jun 26, 2023
@DaviRain-Su
Remove Header trait (#617) from IBC crate. (#730)
e2c3d13 
* Remove Header trait (#617) from IBC crate.

* Remove query_latest_header() definition from MockContext and related code cleanup.
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Jun 26, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.42.0 milestone Jun 27, 2023
Farhad-Shabani pushed a commit that referenced this issue Sep 9, 2024
@DaviRain-Su
Remove Header trait (#617) from IBC crate. (#730)
74c45ac 
* Remove Header trait (#617) from IBC crate.

* Remove query_latest_header() definition from MockContext and related code cleanup.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews O: code-hygiene Objective: aims to improve code hygiene
Projects
None yet
Milestone
v0.42.0
Development

Successfully merging a pull request may close this issue.

Remove Header trait (#617) from IBC crate.
3 participants
@plafer @DaviRain-Su @Farhad-Shabani