Code clean-up remained from v0.37.0 #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
- Coverage 73.19% 73.19% -0.01%
==========================================
Files 125 125
Lines 15660 15659 -1
==========================================
- Hits 11463 11462 -1
Misses 4197 4197
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
plafer
approved these changes
Apr 14, 2023
Signed-off-by: Philippe Laferrière <plafer@protonmail.com>
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* Code clean-up remained from v0.37.0 * Revise pr number * Adapt changelog * Update .changelog/unreleased/breaking-changes/622-v0.37.0-cleanup.md Signed-off-by: Philippe Laferrière <plafer@protonmail.com> --------- Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Co-authored-by: Philippe Laferrière <plafer@protonmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Caught my eye while reviewing different message types for adding missing checks.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.