Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ClientState has methods only used in tendermint client #681

Closed
plafer opened this issue May 17, 2023 · 0 comments · Fixed by #682
Closed

ClientState has methods only used in tendermint client #681

plafer opened this issue May 17, 2023 · 0 comments · Fixed by #682
Assignees
@plafer
Labels
A: breaking Admin: breaking change that may impact operators
Milestone
v0.41.0

Comments

@plafer
Copy link
Contributor

plafer commented May 17, 2023

chain_id() and zero_custom_fields() are not used by the core handlers; hence, they're tendermint-specific, and should be moved strictly to the tendermint client.
@plafer plafer mentioned this issue May 17, 2023
Merged
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs May 17, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.41.0 milestone May 17, 2023
@Farhad-Shabani Farhad-Shabani moved this from 📥 To Do to ✅ Done in ibc-rs May 17, 2023
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label May 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@plafer plafer

Labels
A: breaking Admin: breaking change that may impact operators
Projects
None yet
Milestone
v0.41.0
Development

Successfully merging a pull request may close this issue.

Cleanup ClientState methods informalsystems/ibc-rs
2 participants
@plafer @Farhad-Shabani