Skip to content

Make ICS-20's Amount type transparent #684

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Tracked by #608
plafer opened this issue May 18, 2023 · 0 comments · Fixed by #685
Closed
Tracked by #608

Make ICS-20's Amount type transparent #684

plafer opened this issue May 18, 2023 · 0 comments · Fixed by #685
Assignees
@plafer
Milestone
v0.41.0

Comments

@plafer
Copy link
Contributor

plafer commented May 18, 2023

We received feedback from @keppel that the Amount type's API is needlessly restrictive. We should simply define it as

pub struct Amount(pub U256);

to let users access the underlying value however they want
@plafer plafer self-assigned this May 18, 2023
@plafer plafer mentioned this issue May 18, 2023
Merged
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs May 18, 2023
@Farhad-Shabani Farhad-Shabani moved this from 📥 To Do to 🏗️ In Progress in ibc-rs May 18, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in ibc-rs May 23, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.41.0 milestone May 23, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue May 23, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@plafer plafer

Labels
None yet
Projects
None yet
Milestone
v0.41.0
Development

Successfully merging a pull request may close this issue.

Fix ICS-20 Amount type informalsystems/ibc-rs
2 participants
@plafer @Farhad-Shabani