Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Re-export all crates that have types present in our public API #697

Closed
plafer opened this issue May 31, 2023 · 0 comments · Fixed by #975
Closed

Re-export all crates that have types present in our public API #697

plafer opened this issue May 31, 2023 · 0 comments · Fixed by #975
Assignees
Labels
O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Milestone

Comments

@plafer
Copy link
Contributor

plafer commented May 31, 2023

For example, our public API requires ibc_proto::google::protobuf::Any. We should thus re-export ibc_proto in our lib.rs.

This will have many benefits:

  1. When users upgrade their ibc-rs dependency (not through cargo update), it will just work, as opposed to showing a bunch of errors which effectively mean "upgrade ibc-proto as well".
  2. It will make the ClientState derive macro (implemented in Static ClientState API #683) slightly cleaner (i.e. users will be allowed to rename their ibc_proto without breaking the macro).
@plafer plafer added the O: usability Objective: aims to enhance user experience (UX) and streamline product usability label May 31, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Jun 1, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Nov 22, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.48.0 milestone Nov 24, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Nov 24, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants