Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ICS07] Add test to ensure PacketData keeps proper JSON encoding #763

Closed
Tracked by #807
Farhad-Shabani opened this issue Jul 14, 2023 · 0 comments · Fixed by #765
Closed
Tracked by #807

[ICS07] Add test to ensure PacketData keeps proper JSON encoding #763

Farhad-Shabani opened this issue Jul 14, 2023 · 0 comments · Fixed by #765
Assignees
Labels
O: code-hygiene Objective: aims to improve code hygiene O: testing Objective: aims to improve testing coverage
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Background

When serializing PacketData to JSON, it should be converted to RawPacketData first. Encoding PacketData directly may not yield the same result. Nice to add a unit test for including the proper conversion. Additionally, trim places PacketData is used in our tests.

This originated from a discussion in #741 about whether can drop this serde attribute.

@Farhad-Shabani Farhad-Shabani added O: testing Objective: aims to improve testing coverage O: code-hygiene Objective: aims to improve code hygiene labels Jul 14, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Jul 14, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Jul 14, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.43.0 milestone Jul 17, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Jul 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
O: code-hygiene Objective: aims to improve code hygiene O: testing Objective: aims to improve testing coverage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant