Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve error handling when decoding Any to MsgEnvelope #950

Closed
Tracked by #270
Farhad-Shabani opened this issue Nov 7, 2023 · 0 comments · Fixed by #1350
Closed
Tracked by #270

Improve error handling when decoding Any to MsgEnvelope #950

Farhad-Shabani opened this issue Nov 7, 2023 · 0 comments · Fixed by #1350
Assignees
@seanchen1991
Labels
S: errors Scope: related to error handlings
Milestone
0.55.0

Comments

@Farhad-Shabani
Copy link
Member

Problem Statement

Currently, when converting an incoming IBC message of Any type to a MsgEnvelope, we are mapping decoding errors to a variant of RouterError (e.g. here), leading to confusion. Thus, this issue should aim to:

  • Fix incorrect mapping
  • Utilize more efficient manner to capture the source error

We came across this issue in #949 and it is currently blocked on #270. We can address this after refactoring our error handling system.
@Farhad-Shabani Farhad-Shabani added A: blocked Admin: blocked by another (internal/external) issue or PR S: errors Scope: related to error handlings labels Nov 7, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Nov 7, 2023
@Farhad-Shabani Farhad-Shabani changed the title Improve Error handling when decoding Any to MsgEnvelope Improve error handling when decoding Any to MsgEnvelope Nov 7, 2023
@seanchen1991 seanchen1991 mentioned this issue Jun 4, 2024
Closed
@Farhad-Shabani Farhad-Shabani mentioned this issue Aug 12, 2024
Open
@seanchen1991 seanchen1991 self-assigned this Sep 5, 2024
@seanchen1991 seanchen1991 removed the A: blocked Admin: blocked by another (internal/external) issue or PR label Sep 5, 2024
@Farhad-Shabani Farhad-Shabani mentioned this issue Sep 24, 2024
Merged
15 tasks
@Farhad-Shabani Farhad-Shabani added this to the 0.55.0 milestone Sep 24, 2024
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Sep 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@seanchen1991 seanchen1991

Labels
S: errors Scope: related to error handlings
Projects
None yet
Milestone
0.55.0
Development

Successfully merging a pull request may close this issue.

imp(ibc)!: refactor error handling throughout codebase informalsystems/ibc-rs
2 participants
@seanchen1991 @Farhad-Shabani