imp: re-export Timestamp & Duration from ibc_proto::google::protobuf
#1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
=======================================
Coverage 71.30% 71.30%
=======================================
Files 187 187
Lines 18507 18507
=======================================
Hits 13196 13196
Misses 5311 5311 ☔ View full report in Codecov by Sentry. |
rnbguy
requested changes
Jan 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
==========================================
- Coverage 67.05% 67.04% -0.02%
==========================================
Files 204 205 +1
Lines 20552 20567 +15
==========================================
+ Hits 13782 13789 +7
- Misses 6770 6778 +8 ☔ View full report in Codecov by Sentry. |
Farhad-Shabani
changed the title
ibc_proto::google::protobufTimestamp & Duration from ibc_proto::google::protobuf
Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
…obuf` (#1054) * imp: re-export all the proto type under ibc_proto::google::protobuf * fix: re-export a few necessary types --------- Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This requirement emerged while implementing the
sov-celestialight client, eliminating the need to import the same types fromtendermint_proto::google::protobuf.PR author checklist:
unclog.docs/).