Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve compatibility between tendermint-rs's Time and ibc-rs's Timestamp types #1323

Closed
2 tasks
seanchen1991 opened this issue Aug 26, 2024 · 0 comments · Fixed by #1353
Closed
2 tasks
Assignees
Milestone

Comments

@seanchen1991
Copy link
Contributor

seanchen1991 commented Aug 26, 2024

Feature Summary

Following the work done in #1307, ibc-rs's Timestamp type no longer relies upon tendermint-rs's Time type. Both of these types now co-exist, each one wrapping a private PrimitiveDateTime. For better interoperability between these co-existing types, at least one of them should expose the underlying PrimitiveDateTime type.

Proposal

There are multiple avenues for how compatibility between these two types can be improved:

  • Add conversions in the form of TryFrom<PrimitiveDateTime> and Into<PrimitiveDateTime> for the Timestamp type
  • Allow host and consensus states to introduce their own timestamp types
@seanchen1991 seanchen1991 self-assigned this Aug 26, 2024
@seanchen1991 seanchen1991 changed the title Make the PrimitiveDateTime field of Timestamp public Improve compatibility between tendermint-rs's Time and ibc-rs's Timestamp types Aug 27, 2024
@Farhad-Shabani Farhad-Shabani added this to the 0.55.0 milestone Sep 24, 2024
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Sep 24, 2024
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Sep 26, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants