Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Signer parsing from context #1393

Merged

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented Jan 17, 2025

Based on #1392

Diff: https://github.com/heliaxdev/cosmos-ibc-rs/compare/heliaxdev:cosmos-ibc-rs:tiago/optional-ack-rebased..heliaxdev:cosmos-ibc-rs:tiago/signer-parsing-from-ctx

Description

This PR replaces the TryFrom<Signer> bound on AccountId with new context methods, with the aim of contextually parsing Signer instances.

(Some context: #1392 (comment))


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

sug0 added a commit to heliaxdev/cosmos-ibc-rs that referenced this pull request Jan 17, 2025
@sug0 sug0 mentioned this pull request Jan 17, 2025
7 tasks
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 19.23077% with 21 lines in your changes missing coverage. Please review.

Project coverage is 67.13%. Comparing base (27f10ac) to head (5115168).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/testapp/ibc/applications/nft_transfer/context.rs 0.00% 6 Missing ⚠️
...-apps/ics20-transfer/src/handler/on_recv_packet.rs 0.00% 3 Missing ⚠️
.../ics721-nft-transfer/src/handler/on_recv_packet.rs 0.00% 3 Missing ⚠️
...t/src/testapp/ibc/applications/transfer/context.rs 50.00% 3 Missing ⚠️
ibc-apps/ics20-transfer/src/handler/mod.rs 0.00% 2 Missing ⚠️
ibc-apps/ics721-nft-transfer/src/handler/mod.rs 0.00% 2 Missing ⚠️
...s/ics721-nft-transfer/src/handler/send_transfer.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1393      +/-   ##
==========================================
+ Coverage   67.07%   67.13%   +0.05%     
==========================================
  Files         226      226              
  Lines       22485    22455      -30     
==========================================
- Hits        15082    15075       -7     
+ Misses       7403     7380      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting out this PR! Please take a look at the comments. Additionally:

sug0 added a commit to heliaxdev/cosmos-ibc-rs that referenced this pull request Jan 20, 2025
@sug0 sug0 force-pushed the tiago/signer-parsing-from-ctx branch from 12ffb4b to 76b9943 Compare January 20, 2025 09:11
sug0 added a commit to heliaxdev/cosmos-ibc-rs that referenced this pull request Jan 20, 2025
@sug0 sug0 force-pushed the tiago/signer-parsing-from-ctx branch from 76b9943 to 6f5becd Compare January 20, 2025 09:25
@sug0 sug0 requested a review from Farhad-Shabani January 20, 2025 09:25
@sug0 sug0 force-pushed the tiago/signer-parsing-from-ctx branch from 6f5becd to 5115168 Compare January 21, 2025 09:11
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Farhad-Shabani Farhad-Shabani added this pull request to the merge queue Jan 21, 2025
Merged via the queue into informalsystems:main with commit a5f9fbf Jan 21, 2025
12 of 13 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants