Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Derive borsh for MsgEnvelope #846

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Derive borsh for MsgEnvelope #846

merged 3 commits into from
Sep 1, 2023

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Aug 31, 2023

No description provided.

@plafer plafer marked this pull request as ready for review August 31, 2023 19:51
@plafer plafer requested a review from Farhad-Shabani August 31, 2023 19:51
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 70.40% and project coverage change: +0.03% 🎉

Comparison is base (1833df5) 71.55% compared to head (5a47ddd) 71.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
+ Coverage   71.55%   71.59%   +0.03%     
==========================================
  Files         124      124              
  Lines       15044    15142      +98     
==========================================
+ Hits        10765    10841      +76     
- Misses       4279     4301      +22     
Files Changed Coverage Δ
crates/ibc/src/core/ics02_client/msgs.rs 94.11% <0.00%> (-5.89%) ⬇️
...es/ibc/src/core/ics02_client/msgs/create_client.rs 87.09% <0.00%> (-2.91%) ⬇️
...tes/ibc/src/core/ics02_client/msgs/misbehaviour.rs 4.34% <0.00%> (-0.20%) ⬇️
...es/ibc/src/core/ics02_client/msgs/update_client.rs 87.09% <0.00%> (-2.91%) ⬇️
...s/ibc/src/core/ics02_client/msgs/upgrade_client.rs 75.34% <0.00%> (-1.05%) ⬇️
crates/ibc/src/core/ics03_connection/msgs.rs 92.85% <0.00%> (-7.15%) ⬇️
...bc/src/core/ics03_connection/msgs/conn_open_ack.rs 91.00% <0.00%> (-0.92%) ⬇️
...rc/core/ics03_connection/msgs/conn_open_confirm.rs 89.13% <0.00%> (-1.99%) ⬇️
crates/ibc/src/core/ics04_channel/msgs.rs 85.00% <0.00%> (-9.45%) ⬇️
...ibc/src/core/ics04_channel/msgs/acknowledgement.rs 74.00% <0.00%> (-1.52%) ⬇️
... and 13 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plafer plafer merged commit 2c28380 into main Sep 1, 2023
@plafer plafer deleted the plafer/borsh-msg-envelope branch September 1, 2023 13:08
@Farhad-Shabani Farhad-Shabani added this to the v0.45.0 milestone Sep 7, 2023
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* Add BorshSerialize/Deserialize to MsgEnvelope

* add tests

* changelog
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants