Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix dockerfile #392

Closed
wants to merge 1 commit into from
Closed

Fix dockerfile #392

wants to merge 1 commit into from

Conversation

orkunkl
Copy link
Contributor

@orkunkl orkunkl commented Jan 27, 2021 •
edited
Loading

  • Fix dependencies
  • Set runtime os to latest(stable version)
  • Remove user configurations to make things simpler, you can discard the change if you want.

colin-axner
colin-axner approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @marbar3778 could you take a quick peak 🙏

tac0turtle
tac0turtle reviewed Jan 27, 2021
View reviewed changes
Dockerfile

ENV RELAYER /relayer

RUN addgroup rlyuser && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but why use the sudo user?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur, could we add it back? Using users aligns with gaia dockerfile and anyone using a relayer in production should know how to run the relayer in a docker container as a regular user

@colin-axner
Copy link
Contributor

#462 includes the relevant changes

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tac0turtle tac0turtle tac0turtle left review comments

@colin-axner colin-axner colin-axner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orkunkl @colin-axner @tac0turtle