Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chain: retry on db failure #478

Merged
merged 23 commits into from
Mar 29, 2021
Merged

chain: retry on db failure #478

merged 23 commits into from
Mar 29, 2021

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Mar 28, 2021

This is a temporary patch until a revision of the relayer's architecture takes place. Namely, this PR introduces a patch that performs a re-attempt of MustGetLatestLightHeight upon a database error. This prevents a running relayer from halting, which may further cause expired clients or "stuck" packets.

I've also removed some cruft from the test/build area and introduced a more reliable two-chains testing setup. In future PRs, I'd like to remove all the one-off scripts and configs and rely on a more robust docker-driven testing system.

closes: #444

cc @colin-axner

version: "3.9"
services:
ibc-0:
image: "tendermint/gaia:v4.2.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: we rely on a gaia image directly, instead of a contributor-specific image

@alexanderbez alexanderbez marked this pull request as ready for review March 29, 2021 15:05
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work! Relayer is looking better already!

@colin-axner colin-axner merged commit 56c88b6 into master Mar 29, 2021
@colin-axner colin-axner deleted the bez/db-lock-tmp-patch branch March 29, 2021 16:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic in light client db
2 participants