Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix Timeout Handling on Relayer start #506

Merged
merged 2 commits into from
May 10, 2021
Merged

Fix Timeout Handling on Relayer start #506

merged 2 commits into from
May 10, 2021

Conversation

AdityaSripal
Copy link
Member

@AdityaSripal AdityaSripal commented May 7, 2021 •
edited
Loading

Need to swap src and dst

Timeout handling on streaming relayer still unimplemented

TESTED on two-chainz and it works

@AdityaSripal AdityaSripal requested a review from jackzampolin May 7, 2021 20:57
colin-axner
colin-axner approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add a changelog?

@AdityaSripal AdityaSripal enabled auto-merge (squash) May 10, 2021 15:07
@AdityaSripal AdityaSripal merged commit 9eede44 into master May 10, 2021
@AdityaSripal AdityaSripal deleted the aditya/timeout-fix branch May 10, 2021 15:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@fedekunze fedekunze Awaiting requested review from fedekunze

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdityaSripal @colin-axner