Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update BlockTransactionsResponse #121

Closed
JulianToledano opened this issue Apr 30, 2024 · 0 comments · Fixed by #123
Closed

Update BlockTransactionsResponse #121

JulianToledano opened this issue Apr 30, 2024 · 0 comments · Fixed by #123
Assignees
@JulianToledano

Comments

@JulianToledano
Copy link
Contributor

#119 pointed that BeginBlock and EndBlock were just duplicated.

Turns out Comets ResultBlockResults changed from 0.37.x to 0.38.x.

0.37.x

https://github.com/cometbft/cometbft/blob/7f24fd2b41c3fc734e6020b4d9a46fa07bebc4db/rpc/core/types/responses.go#L53-L61

0.38.x

https://github.com/cometbft/cometbft/blob/1b1216cbbd945a8f1d679904b2fa7ebf3ff0fb1f/rpc/core/types/responses.go#L53-L61

BlockTransactionsResponse should be updated following the Rosetta specification.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@JulianToledano JulianToledano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update blockTxs to correctly parse finalizeblock events cosmos/rosetta
1 participant
@JulianToledano