Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Integrate with Cosmos SDK v0.50 #18

Closed
julienrbrt opened this issue Jul 31, 2023 · 3 comments
Closed

Integrate with Cosmos SDK v0.50 #18

julienrbrt opened this issue Jul 31, 2023 · 3 comments
Assignees
Labels

Comments

@julienrbrt
Copy link
Member

I think Rosetta should start integrating with v0.50 to be ready to be tagged when Cosmos SDK v0.50 is released.

@julienrbrt julienrbrt changed the title Integrate to Cosmos SDK v0.50 Integrate with Cosmos SDK v0.50 Jul 31, 2023
@bizk bizk self-assigned this Aug 22, 2023
@bizk
Copy link
Contributor

bizk commented Aug 25, 2023

Changes on cosmos-sdk v0.50 are causing unexpected errrors on parts of the code that were already working before.
I'm investgating if this is a bug on cosmos-sdk side, or something about the usage of such module that needs to be reworked.

The function error is on
func (t *Tx) GetSigners(cdc codec.Codec) ([][]byte, []protov2.Message, error)
In particular over:
xs, msgv2, err := cdc.GetMsgAnySigners(msg)

The error states: `InterfaceRegistry requires a proper address codec implementation to do address conversion'

@julienrbrt
Copy link
Member Author

julienrbrt commented Aug 25, 2023

You probably need signing options:

https://github.com/cosmos/cosmos-sdk/blob/860ab2fa7229227b79f9815e3693df1efb8dbca6/simapp/app.go#L195:L203

@bizk
Copy link
Contributor

bizk commented Aug 25, 2023

Implemented the optionss, seems it doesn't like it, I will try to register the interface and see how it works

@bizk bizk closed this as completed Sep 1, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants