Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

widen main content pane #10

Closed
rpfong0 opened this issue Apr 14, 2022 · 2 comments · Fixed by #12
Closed

widen main content pane #10

rpfong0 opened this issue Apr 14, 2022 · 2 comments · Fixed by #12

Comments

@rpfong0
Copy link
Contributor

rpfong0 commented Apr 14, 2022

We may consider widening the main content pane. Someone showed me Flux which fills a landscape screen. I'm not sure if there's a reason why the default Antora style leaves a gap on the right.

@countableSet
Copy link
Owner

I noticed that too and thought it was a little weird when I was using my laptop screen, but didn't notice it was much when using a monitor, I suppose my windows size is smaller on the monitor. Seems reasonable to improve it 👍🏻 I don't think there's a reason why Antora style leaves such a gap. 🤷🏻‍♀️

Looks like there's a issues open for it https://gitlab.com/antora/antora-ui-default/-/issues/157 open 1 year ago 😱

@countableSet
Copy link
Owner

Current toc width is around 216px on my 14in laptop screen.
Screen Shot 2022-04-19 at 10 13 38 PM

which aligns with

--toc-width: calc(162 / var(--rem-base) * 1rem);
--toc-width--widescreen: calc(216 / var(--rem-base) * 1rem);
--doc-max-width: calc(720 / var(--rem-base) * 1rem);
--doc-max-width--desktop: calc(828 / var(--rem-base) * 1rem);

Flux width is percentage based, around 16.6666%
Screen Shot 2022-04-19 at 10 09 21 PM

We can switch to a percentage as well, something around 235px instead look ok.
Screen Shot 2022-04-19 at 10 16 36 PM

Before After
Screen Shot 2022-04-19 at 10 19 12 PM Screen Shot 2022-04-19 at 10 19 29 PM

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants