Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

isVersionCompatible should use version compability, not equality #307

Open
brynrhodes opened this issue May 22, 2023 · 2 comments
Open

isVersionCompatible should use version compability, not equality #307

brynrhodes opened this issue May 22, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@brynrhodes
Copy link
Member

In the following test for version compatibility:

This will in general always fail because the compability level is expressed as major.minor, where the implementation version will be specified to the patch level, and potentially include a snapshot label.

@brynrhodes brynrhodes added the bug Something isn't working label May 22, 2023
@JPercival
Copy link
Contributor

That's intentional. We don't currently consider how ELM generation is impacted in the major.minor.bugfix versions in the cql compiler so have to assume that a mismatched version is not compatible. For example, this change here:

cqframework/clinical_quality_language#1163

required runtime changes to support correctly and (intentionally, due to performance considerations) pushed overload resolution from runtime to compile time.

@JPercival
Copy link
Contributor

Ah. Actually, I interpreted your comment backwards. The code looks at the compatibility level and not the implementation version. You are right. That's incorrect.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants