User logged out when trying to verify a changed email address

[angrybrad]

Description

When trying to verify a new email address of an existing user by clicking the link in the email, after changing it in a front-end "edit account" form, logged-in users get logged out by UsersController::_processTokenRequest().

They then have to log back in continue editing their profile. This feels like bad UX workflow for existing accounts.

Related issue: #1422

One workaround in Craft 2 is to write a plugin that does something like:

craft()->on('userSession.beforeLogout', function(Event $event) 
{ 
    $user = $event->params['user'];

    if ($user->unverifiedEmail) 
    { 
        craft()->userSession->setNotice(Craft::t('Your email address has been updated.'));

        $event->performAction = false; 
    } 
});

Steps to reproduce

1. Create a front-end login, register and edit profile form.
2. Register a new user.
3. Change that users email address.
4. Click on link in email. Email is verified, but you get logged out.

Additional info

• Craft version: 2.x and 3.x
• PHP version: n/a
• Database driver & version: n/a
• Plugins & versions: n/a