Mysql: 'wrong' restore command

[ostark]

Description

I didn't know that we can use mysqldump to restore/import a MySQL database. I could not find anything in the official docs, just some rare answers on stack overflow.

In my tests the mysqldumpcommand gets executed without any errors, but it does nothing with the database. Maybe it works with a different version, I use the one from MariaDB.

Code

public function getDefaultRestoreCommand(): string
    {
        return 'mysqldump'.
            ' --defaults-extra-file="'.$this->_createDumpConfigFile().'"'.
            ' {database}'.
            ' < "{file}"';
    }

Fix

In my opinion it should be mysql {database} < {file} instead of mysqldump {database} < {file}.

---

Steps to reproduce

1. Execute \Craft::$app->getDb()->backupTo('path/to/dump.sql');
2. Change some data
3. Execute \Craft::$app->getDb()->restore('path/to/dump.sql');
4. Check if the new or the old data exist in the DB

Additional info

• Craft version: 3.0.1
• PHP version: 7.1
• Database driver & version: mysql Ver 15.1 Distrib 10.1.14-MariaDB, for osx10.11 (x86_64) using readline 5.1