Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fields should default to not-translatable when when don't have a content column #3385

Closed
timkelty opened this issue Oct 18, 2018 · 4 comments
Closed

Fields should default to not-translatable when when don't have a content column #3385

timkelty opened this issue Oct 18, 2018 · 4 comments

Comments

@timkelty
Copy link
Contributor

It seems like potentially a better default for craft\base\Field::supportedTranslationMethods would be to default to [self::TRANSLATION_METHOD_NONE] if field don't have a content column (hasContentColumn returning false).

The default now assumes if a plugin dev is storing things outside of content, they are also making values things multi-site, which probably isn't the case. Since someone would have to intentionally make that field translatable, it makes sense they would have to deal with their own supportedTranslationMethods method.

Example: doublesecretagency/craft-smartmap#21
@timkelty timkelty changed the title Default fields w/o content column to non-translatable Fields should default to not-translatable when when don't have a content column Oct 18, 2018
@brandonkelly
Copy link
Member

Agree, that would be a better default.

@timkelty
Copy link
Contributor Author

👍 I'll PR next time I'm in there

@brandonkelly
Copy link
Member

No need :)

@timkelty
Copy link
Contributor Author

download

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timkelty @brandonkelly