-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Gql doc-only probably, concerning token permits #4992
Comments
Got pinged by github just fine :) I mean, there's no reason to assume that anything would be exposed - not sure if it warrants explicitly mentioning in the docs? |
I don't know, I just had a look at a vm where I don't think I've messed with it, and Public Schema isn't permitted anything. And I presume helloWorld works even if its not enabled?? It does seem though that a concise mention of Public Schema rather up front in the doc would be wise, saying that if you do enable elements etc. there, you'll want to consider security, as then anyone who picks up your [gqlapi!] url will be able to discover, and run queries or worse (upserts), on any of those things. Not least because CraftQL is entirely sealed up for this, and persons may expect it. Hope this isn't too rum, as I am just having completed two days of beating Gridsome's more intricate aspects to the mat... 🐲🐲 |
There already is a concise explanation of this in the docs (https://docs.craftcms.com/v3/graphql.html#define-your-schemas):
|
Well, yes, there is. Then I think we have to ask, why wouldn't this help on the case mentioned, or others I've recently dealt with which actually involved Gql?
-- It's not any place I'm asking you or especially Andris to go, but for the unavoidable nonsequitor errors in mutually unaware but coupled systems as Live Vue arranges, I've simply had to do at-the-moment handholding and focus documentation, which is what Hal the Robot does. Just recognizing a few key error messages and exttending them, though, is a piece of that action which seems it would be good for problems that occur at Craft's boundaries here. Ok, and last point is that you don't always get 'Not authorized' when that's the base problem. I'll write that up in a separate issue, as testing for what's written here turned up the source of a mystery seen before. Cheers both, @andris-sevcenko and @brandonkelly . I don't raise issues just for fun, you know... |
Just discovered something nice which can help with the doco tips part of this... By some care reading (!) over the latest Vuepress documentation, I noticed that you don't have to be restricted to the WARNING letters which made me uncomfortable about recommending the warning level even if it's the appropriate one for purpose. if you specify for example like this:
You guys may know this already, but I was impressed... |
...and, just to add to the meta that's in discussion now, I realize how I learned this little useful factoid:
I think I am not exactly alone, in present day, with operating on this multi-mode wavelength of skim-reading. It is a habit of our over-information activities. Some issues with eyesight remaining also contribute, I'm aware, but don't think I'm alone in this either. Thus, my thought above about the value of giving inter-conversational alternate messages and highlights, as being much more effective. And also easier to write, really... The Vuepress doc section referred to is here: https://vuepress.vuejs.org/guide/markdown.html#custom-containers |
Description
@andris-sevcenko this is just because Github acts funny on mentioning your name on a different repo, so wanted to be sure you had the benefit, not as much my comment as seeing a case where people will get confused etc..
Here's the case: markhuot/craftql#323 (comment), starting actually at the top with his initial frustration...
As a p.s., I'm doing a little support over there, to lay groundwork hoping I won't have to soon with a certain release, same principal as Hal the robot....
The text was updated successfully, but these errors were encountered: