Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve package size #9

Closed
hdl-helsinki opened this issue Jul 26, 2017 · 4 comments
Closed

Improve package size #9

hdl-helsinki opened this issue Jul 26, 2017 · 4 comments
Labels

Comments

@hdl-helsinki
Copy link

font-awesome increases almost 1mb the size of my production script.

think it would be better to load the icons via css or, at least, remove the unneeded icons.

Thank you

@craigh411
Copy link
Owner

Absolutely, I will be sorting this out as soon as I get the chance. The font awesome icons need to be SVG paths, but it certainly isn't necessary to import all icons, so I will look at the best way to remove these from the bundle while still allowing a simple method of importing only the required icon. I have a couple of ideas, so expect an update soon.

@hdl-helsinki
Copy link
Author

Thank you very much.

Maybe you could parse the SVG icons from bootstrap CDN: https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/fonts/fontawesome-webfont.svg

@dmaicher
Copy link

dmaicher commented Sep 2, 2017

Any update on this issue? 😊

I would also like to use your plugin but my js package size increases by 720KB (minified) which is not acceptable for me.

I only really want to use the ImageRating without all the icon stuff.

@craigh411
Copy link
Owner

This issue has now been resolved in Version 2.0 and vue-rate-it is now 18.6 KB. Because it was the font-awesome glyphs that were causing the file bloat there are some changes to how the fa-rating component works, which are documented in the release notes. All other rating components work the same as before, so there shouldn't be any issues upgrading to 2.0 if you are using those.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants