Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Compiling Error When running react-native run-android #77

Open
johndo31 opened this issue Aug 5, 2017 · 3 comments
Open

Compiling Error When running react-native run-android #77

johndo31 opened this issue Aug 5, 2017 · 3 comments

Comments

@johndo31
Copy link

johndo31 commented Aug 5, 2017

Hello,

since upgrading react-native I get the following error:

node_modules\react-native-splash-screen\android\src\main\java\com\cboy\rn\splash
screen\SplashScreenReactPackage.java:22: error: method does not override or implement a method from a supertype
    @Override

Does anyone have a suggestion why this occurs?

Thanks
John

@johndo31
Copy link
Author

johndo31 commented Aug 5, 2017

Found the error with react-native 0.47

public class SplashScreenReactPackage implements ReactPackage {

    //@Override
    //public List<Class<? extends JavaScriptModule>> createJSModules() {
    //    return Collections.emptyList();
    //}

Solved the problem for me.

Is it possible to remove the commented lines in the next release please?

Cheers
John

@radko93
Copy link
Contributor

radko93 commented Aug 10, 2017

There is PR for that #74

@NachtRitter
Copy link

@crazycodeboy can you please merge PR and make release?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants