Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix opcode in Case 3.6. #97

Open
andrey-zelenkov opened this issue Jul 24, 2019 · 1 comment
Open

Fix opcode in Case 3.6. #97

andrey-zelenkov opened this issue Jul 24, 2019 · 1 comment

Comments

@andrey-zelenkov
Copy link

Case Description:

Send Ping with RSV = 6.

But opcode used in Case 3.6 in sendFrame() function is 2 (that corresponds to the binary message):

self.p.sendFrame(opcode = 2, payload = payload, rsv = 6)

Please use opcode = 9 for Ping (or change case description).

@aerique
Copy link

aerique commented Jul 26, 2019

Came here to submit this issue. Was expecting it to be a problem on my end 😃

Output from my tests:

[…]
#S(FRAME :FIN T :RSV1 T :RSV2 T :RSV3 NIL :OPCODE 2 :OPCODE-TYPE :BINARY :MASK NIL :PAYLOAD-LENGTH 13 :MASKING-KEY 0 :PAYLOAD-DATA (72 101 108 108 111 44 32 119 111 114 108 100 33))
CASE-3-6: (FRAME-OPCODE FRAME) failed: 
Expected 9 but saw 2
CASE-3-6: (FRAME-OPCODE-TYPE FRAME) failed: 
Expected :PING but saw :BINARY
CASE-3-6: 3 assertions passed, 2 failed.
[…]

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants