From 550f6e6ca0a552cd57f67842dd6bed718b3fc5fa Mon Sep 17 00:00:00 2001 From: wejdross Date: Mon, 20 Jan 2025 13:15:37 +0100 Subject: [PATCH] add verboser logging for observe.go Signed-off-by: wejdross --- pkg/controller/release/observe.go | 2 +- pkg/controller/release/observe_test.go | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/controller/release/observe.go b/pkg/controller/release/observe.go index 21662c3..f01a8f6 100644 --- a/pkg/controller/release/observe.go +++ b/pkg/controller/release/observe.go @@ -83,7 +83,7 @@ func isUpToDate(ctx context.Context, kube client.Client, spec *v1beta1.ReleaseSp in := spec.ForProvider if in.Chart.Name != ocm.Name { - return false, nil + return false, fmt.Errorf("expected chart name %s, got %s", in.Chart.Name, ocm.Name) } mp := sets.New[xpv1.ManagementAction](spec.ManagementPolicies...) diff --git a/pkg/controller/release/observe_test.go b/pkg/controller/release/observe_test.go index 2894915..072a47f 100644 --- a/pkg/controller/release/observe_test.go +++ b/pkg/controller/release/observe_test.go @@ -2,6 +2,7 @@ package release import ( "context" + "fmt" "testing" xpv1 "github.com/crossplane/crossplane-runtime/apis/common/v1" @@ -230,7 +231,7 @@ func Test_isUpToDate(t *testing.T) { }, want: want{ out: false, - err: nil, + err: fmt.Errorf("expected chart name %s, got %s", "another-chart", testChart), }, }, "NotUpToDate_ChartVersionDifferent": {