Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

[FEATURE] Better user #/signin flow #140

Open
ykdojo opened this issue Aug 28, 2022 · 15 comments
Open

[FEATURE] Better user #/signin flow #140

ykdojo opened this issue Aug 28, 2022 · 15 comments
Assignees
Labels
feat New feature addition or request

Comments

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 28, 2022

Description

We should handle user #s & signins better.

There are many things to do there:

Better error handling, clearly showing that users have signed in (related to #122), etc.

@ykdojo ykdojo added this to defaang Aug 28, 2022
@ykdojo ykdojo moved this to To do in defaang Aug 28, 2022
@subhoghoshX
Copy link
Collaborator

I can work on it once PR #133 is merged.

@subhoghoshX
Copy link
Collaborator

subhoghoshX commented Aug 30, 2022

Alright now that #133 is merged. I'll start working on this one. My plan is to do the following:

  • Show a # link by default in the Header instead of the name & menu
  • When the user is signed in, show their name, email, and the menu
  • Implement Sign Out functionality
  • Bring back the profile picture thing maybe (open to discussion)
  • Show errors in a better way on # and # pages instead of using alerts.

I'll send a series of PRs.

@dattavelivela
Copy link

Hello @subhoghoshX @ykdojo

Can we improve the UX of Sign-up by removing text fields and including "# with google", "# with Twitter", or "# with GitHub", this helps in completing the # process easier for the users to #?

@subhoghoshX
Copy link
Collaborator

Can we improve the UX of Sign-up by removing text fields

Could you elaborate on what you mean by removing the text fields?

And I think PR #114 is working on adding social authentications.

@dattavelivela
Copy link

Oh, I'm saying instead of giving an option to the user to fill in the username or mail and password. We can have social authentications for sign-in and sign-up.

If a user tries to # with an unregistered google account/Apple account/Twitter/Github then

  • They wouldn't be able to # and it displays an error message or notification saying to sign-up

If a user signs in with a registered google account/Twitter/Github/Apple account then

  • Then we can allow the user to # directly.

@subhoghoshX
Copy link
Collaborator

Got it. Thanks. As I mentioned social authentication is already in progress. And I believe we should have both options (social & email/password) as some users prefer email/password login.

@iShibi iShibi changed the title [FEATURE] <Better user #/signin flow> [FEATURE] Better user #/signin flow Sep 5, 2022
@iShibi iShibi added the feat New feature addition or request label Sep 5, 2022
@yaa-chi
Copy link

yaa-chi commented Sep 6, 2022

Hi @subhoghoshX you can check out the user flow here to see if it corresponds with your idea on the sign-up flow: https://www.figma.com/file/DtaNEDhDNz0Wgs4XohV6Pt/Defaang-User-Flow?node-id=0%3A1

@subhoghoshX
Copy link
Collaborator

Already checked it. Thanks for the amazing work @yaa-chi.

@yaa-chi
Copy link

yaa-chi commented Sep 9, 2022

Already checked it. Thanks for the amazing work @yaa-chi.

You're welcome @subhoghoshX . There's more to come!🥳🎉

@Gulshanaggarwal
Copy link
Contributor

Gulshanaggarwal commented Sep 11, 2022

Hey @subhoghoshX , @ykdojo UX experience can be improved when user presses signin or # button. There should be a loading animation on the button or all over the screen. What do you think?

@subhoghoshX
Copy link
Collaborator

Hey @subhoghoshX , @ykdojo UX experience can be improved when user presses signin or # button. There should be a loading animation on the button or all over the screen. What do you think?

Sounds good. I don't see many sites using it though. Open to discussion.

@ykdojo
Copy link
Collaborator Author

ykdojo commented Sep 12, 2022

I think the idea is that this process should be fast enough, a loading screen won't make sense - but open to discussion, too

@yaa-chi
Copy link

yaa-chi commented Oct 10, 2022

I think the idea is that this process should be fast enough, a loading screen won't make sense - but open to discussion, too

I don't think there's a need to have that either. We can have the loading screen somewhere else though👌🏾

@subhoghoshX
Copy link
Collaborator

I don't think there's a need to have that either. We can have the loading screen somewhere else though👌🏾

It's already being implemented in #284 @yaa-chi XD

@yaa-chi
Copy link

yaa-chi commented Oct 11, 2022

@subhoghoshX Just saw it, thanksss

@subhoghoshX subhoghoshX moved this to Todo in defaang Oct 20, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
feat New feature addition or request
Projects
Status: Todo
Development

No branches or pull requests

6 participants