Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

feat: adding home page button on Singup and Signin pages #267

Closed
wants to merge 2 commits into from
Closed

feat: adding home page button on Singup and Signin pages #267

wants to merge 2 commits into from

Conversation

rupali-codes
Copy link

πŸ› οΈ Fixes Issue

Closes #261

βž• Changes Introduced

  • adding defaang home page button in singup page
  • adding defaang home page button in singin page

πŸ“„ Note To Reviewers

πŸ“· Screenshots

Beofre:
image

After:
image

@vercel
Copy link

vercel bot commented Oct 6, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
defaang βœ… Ready (Inspect) Visit Preview Oct 6, 2022 at 8:51AM (UTC)

@github-actions github-actions bot added the title needs formatting Edit PR title to be in line with conventional commit message label Oct 6, 2022
@rupali-codes rupali-codes changed the title [Feature] adding home page button on Singup and Signin pages feat: adding home page button on Singup and Signin pages Oct 6, 2022
@github-actions github-actions bot removed the title needs formatting Edit PR title to be in line with conventional commit message label Oct 6, 2022
Copy link
Collaborator

@ykdojo ykdojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it looks quite right. Maybe it's the position of that logo. The other thing is, people should know how to use the back button. So I'm not sure if we need this button in the first place. If it looks good, it might make sense to add it but if not, it's probably not necessary.

@rupali-codes
Copy link
Author

Yes YK, I was waiting for to finilizing logo, we can try that out, else we will close this pull request.

@rupali-codes rupali-codes closed this by deleting the head repository Dec 17, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Adding back button in # and signin pages
2 participants