Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

feat: Navbar fixed when user scrolls #322

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Navbar fixed when user scrolls #322

wants to merge 2 commits into from

Conversation

joe-shajan
Copy link

🛠️ Fixes Issue

Closes #321

➕ Changes Introduced

  • Made navbar sticky.
  • When scrolled decreased navbar height.
  • Added background color and border to navbar when scrolled.

📄 Note To Reviewers

📷 Screenshots

image
image

@github-actions github-actions bot added the title needs formatting Edit PR title to be in line with conventional commit message label Nov 28, 2022
@joe-shajan joe-shajan changed the title navbar to positon sticky navbar fixed when user scrolls Nov 28, 2022
@joe-shajan joe-shajan changed the title navbar fixed when user scrolls feat: Navbar fixed when user scrolls Nov 28, 2022
@github-actions github-actions bot removed the title needs formatting Edit PR title to be in line with conventional commit message label Nov 28, 2022
@joe-shajan
Copy link
Author

joe-shajan commented Dec 12, 2022 •
edited
Loading

Hey @ykdojo can you please review this feature I implemented?

adilwahla
adilwahla approved these changes Jan 7, 2023 •
edited
Loading
View reviewed changes
adilwahla
adilwahla reviewed Jan 24, 2023
View reviewed changes
Copy link
Contributor

@adilwahla adilwahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@adilwahla adilwahla adilwahla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Sticky Navbar
2 participants
@joe-shajan @adilwahla