Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

unzip output is flattened in windows #220

Closed
YounGoat opened this issue Apr 27, 2018 · 2 comments
Closed

unzip output is flattened in windows #220

YounGoat opened this issue Apr 27, 2018 · 2 comments

Comments

@YounGoat
Copy link

In version 0.4.9, entry name will be escaped in Windows:

function escapeFileName(/*String*/filename){
    return filename.replace(/[\:,\/,\>,\<,\",\\,\|,\?,\*"]/g, '_');
}

Unfortunately, because slash / is also replaced with underscore _, the output will be flattened without any directories reserved.

@DanWahlin
Copy link

DanWahlin commented May 7, 2018

I ran into this today as well on Windows (works fine on my Mac) with 0.4.9 - broke a build process we have. Really appreciate the info. Went back to 0.4.7 and it worked fine on the Windows box.

@nonoroazoro
Copy link

nonoroazoro commented May 8, 2018

Me too on window (win 7), while mac is OK (since adm-zip v0.4.8)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants